IGNITE-27086 Optimize writing Map by BinaryWriterExImpl#12532
Merged
nizhikov merged 18 commits intoapache:masterfrom Dec 2, 2025
Merged
IGNITE-27086 Optimize writing Map by BinaryWriterExImpl#12532nizhikov merged 18 commits intoapache:masterfrom
nizhikov merged 18 commits intoapache:masterfrom
Conversation
timoninmaxim
reviewed
Dec 2, 2025
| private final BinaryWriterSchemaHolder schema; | ||
|
|
||
| /** */ | ||
| private final boolean failIfUnregistered; |
Member
There was a problem hiding this comment.
It looks like you just move some fields - failIfUnregistered, handles, mapper. Can we revert these changes?
There was a problem hiding this comment.
I grouped final and non final variables together just to make it more readable.
Yes, we can revert grouping easily, but, looks like having all changing state together more reliable way to list class variables.
timoninmaxim
requested changes
Dec 2, 2025
|
|
||
| /** Clears writer state. */ | ||
| private void clearState() { | ||
| this.typeId = 0; |
| ); | ||
|
|
||
| writer.marshal(obj); | ||
| int typeId0 = this.typeId; |
Member
There was a problem hiding this comment.
AFAIU, the goal of storing this fields is that they are used in #postWrite method that will be called within marshal(obj). I thinks it's worth to mention that in a comment.
|
timoninmaxim
approved these changes
Dec 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
The Contribution Checklist
The description explains WHAT and WHY was made instead of HOW.
The following pattern must be used:
IGNITE-XXXX Change summarywhereXXXX- number of JIRA issue.(see the Maintainers list)
the
green visaattached to the JIRA ticket (see TC.Bot: Check PR)Notes
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com #ignite channel.